Skip to content

SPECS: enchant: Align provider build conditions#499

Merged
misaka00251 merged 1 commit into
openRuyi-Project:mainfrom
Jingwiw:cleanup-bcond/enchant-spell-provider-options
Jun 2, 2026
Merged

SPECS: enchant: Align provider build conditions#499
misaka00251 merged 1 commit into
openRuyi-Project:mainfrom
Jingwiw:cleanup-bcond/enchant-spell-provider-options

Conversation

@Jingwiw

@Jingwiw Jingwiw commented May 23, 2026

Copy link
Copy Markdown
Member

Changes

  • Make the disabled aspell and nuspell bconds explicit in configure arguments.

    The current default build only enables the hunspell and voikko providers. The spec already keeps aspell and nuspell BuildRequires and packaged backend files behind disabled bconds, while upstream provider detection defaults to check. Passing --without-aspell and --without-nuspell keeps the declared bconds aligned with the current default build fact.

    Source: configure.ac

    AC_ARG_WITH([$1],
       AS_HELP_STRING([--with-[]$1],
          [enable the $1 provider @<:@default=provider_check@:>@]),
          [with_[]$1=$withval],
          [with_[]$1=provider_check])

    Source: configure.ac

    ENCHANT_CHECK_PKG_CONFIG_PROVIDER([nuspell], [NUSPELL], [nuspell >= 5.1.0])
    ENCHANT_CHECK_LIB_PROVIDER([aspell], [ASPELL], [get_aspell_dict_info_list],,, [ASPELL_H])

AIGC Declaration: CodeX with gpt5.5 was used as coding agent.

Signed-off-by: Jingwiw wangjingwei@iscas.ac.cn

Signed-off-by: Jingwiw <wangjingwei@iscas.ac.cn>
@openruyi-bot openruyi-bot Bot added BuildSystem: autotools Issue/PR related to autotools BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Ready For Review Ready for review by anyone with domain expertise. labels May 23, 2026
@misaka00251 misaka00251 added the AI Assistance AI is used to help with portions of code, tests, or documentation. label May 25, 2026
@misaka00251 misaka00251 added this to the 2026.06 milestone Jun 2, 2026
@openruyi-bot openruyi-bot Bot added Workflow: In Review Issues that are undergoing code review and/or undergoing design review. and removed Workflow: Ready For Review Ready for review by anyone with domain expertise. labels Jun 2, 2026
@misaka00251 misaka00251 merged commit 12b56dc into openRuyi-Project:main Jun 2, 2026
3 checks passed
@openruyi-bot openruyi-bot Bot added Workflow: Complete Applied after all MRs have merged and the issue has been verified if necessary. and removed Workflow: In Review Issues that are undergoing code review and/or undergoing design review. labels Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Assistance AI is used to help with portions of code, tests, or documentation. BuildSystem: autotools Issue/PR related to autotools BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Complete Applied after all MRs have merged and the issue has been verified if necessary.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants